tclobj.c

Bug Summary

File:	d/tclobj.c
Warning:	line 104, column 32 Using a fixed address is not portable because that address will probably not be valid in all environments or platforms

Annotated Source Code

Press '?' to see keyboard shortcuts

Show analyzer invocation

clang -cc1 -cc1 -triple x86_64-unknown-linux-gnu -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name tclobj.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 2 -fhalf-no-semantic-interposition -mframe-pointer=none -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/home/isvv/naviserver/nsd -resource-dir /usr/local/lib/clang/15.0.0 -D _FORTIFY_SOURCE=2 -D NDEBUG -D SYSTEM_MALLOC -I ../include -I /usr/include/tcl8.6 -D HAVE_CONFIG_H -internal-isystem /usr/local/lib/clang/15.0.0/include -internal-isystem /usr/local/include -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/11/../../../../x86_64-linux-gnu/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -O2 -std=c99 -fdebug-compilation-dir=/home/isvv/naviserver/nsd -ferror-limit 19 -stack-protector 2 -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -analyzer-checker alpha -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /tmp/scan-build-2022-07-23-130959-11103-1 -x c tclobj.c

1/*
* The contents of this file are subject to the Mozilla Public License
* Version 1.1 (the "License"); you may not use this file except in
* compliance with the License. You may obtain a copy of the License at
* http://mozilla.org/.
*
* Software distributed under the License is distributed on an "AS IS"
* basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
* the License for the specific language governing rights and limitations
* under the License.
*
* The Original Code is AOLserver Code and related documentation
* distributed by AOL.
*
* The Initial Developer of the Original Code is America Online,
* Inc. Portions created by AOL are Copyright (C) 1999 America Online,
* Inc. All Rights Reserved.
*
* Alternatively, the contents of this file may be used under the terms
* of the GNU General Public License (the "GPL"), in which case the
* provisions of GPL are applicable instead of those above.  If you wish
* to allow use of your version of this file only under the terms of the
* GPL and not to allow others to use your version of this file under the
* License, indicate your decision by deleting the provisions above and
* replace them with the notice and other provisions required by the GPL.
* If you do not delete the provisions above, a recipient may use your
* version of this file under either the License or the GPL.
*/


31/*
* tclobj.c --
*
*      Helper routines for managing Tcl_Obj types.
*/

37#include "nsd.h"

39/*
* Local functions defined in this file.
*/

43static Tcl_UpdateStringProc UpdateStringOfAddr;
44static Tcl_SetFromAnyProc   SetAddrFromAny;

46/*
* Local variables defined in this file.
*/

50static const Tcl_ObjType addrType = {
  "ns:addr",
  NULL((void*)0),
  NULL((void*)0),
  UpdateStringOfAddr,
  SetAddrFromAny
56};

58static const Tcl_ObjType *byteArrayTypePtr; /* For NsTclObjIsByteArray(). */
59static const Tcl_ObjType *properByteArrayTypePtr;  /* For NsTclObjIsByteArray(). */
60
61/*
*----------------------------------------------------------------------
*
* NsTclInitAddrType --
*
*      Initialize the Tcl address object type and cache the bytearray Tcl
*      built-in type. Starting with Tcl 8.7a1, Tcl has actually two different
*      types for bytearrays, the old "tclByteArrayType" and a new
*      "properByteArrayType", where both have the string name "bytearray".
*
* Results:
*      None.
*
* Side effects:
*      None.
*
*----------------------------------------------------------------------
*/

80void
81NsTclInitAddrType(void)
82{
  Tcl_Obj *newByteObj;

  Tcl_RegisterObjType(&addrType);
  /*
   * Get the "tclByteArrayType" via name "bytearray".
   */
  byteArrayTypePtr = Tcl_GetObjType("bytearray");

  /*
   * Get the "properByteArrayType" via a TclObj.
   * In versions before Tcl 8.7, both values will be the same.
   */
  newByteObj = Tcl_NewByteArrayObj(NULL((void*)0), 0);
  properByteArrayTypePtr = newByteObj->typePtr;
  if (properByteArrayTypePtr == byteArrayTypePtr) {
1
Assuming 'properByteArrayTypePtr' is equal to 'byteArrayTypePtr'→
2
←
Taking true branch→
      /*
       * When both values are the same, we are in a Tcl version before 8.7,
       * where we have no properByteArrayTypePtr. So set it to an invalid
       * value to avoid potential confusions. Without this stunt, we would
       * need several ifdefs.
       */
      properByteArrayTypePtr = (Tcl_ObjType *)INT2PTR(0xffffff)((void *)(intptr_t)(0xffffff));
3
←
Using a fixed address is not portable because that address will probably not be valid in all environments or platforms
  }
  Tcl_DecrRefCount(newByteObj)do { Tcl_Obj *_objPtr = (newByteObj); if (_objPtr->refCount
-- <= 1) { TclFreeObj(_objPtr); } } while(0);
107}

109
110/*
*----------------------------------------------------------------------
*
* Ns_TclResetObjType --
*
*      Reset the given Tcl_Obj type, freeing any type specific
*      internal representation. The new Tcl_Obj type might be NULL.
*
* Results:
*      None.
*
* Side effects:
*      Depends on object type.
*
*----------------------------------------------------------------------
*/

127void
128Ns_TclResetObjType(Tcl_Obj *objPtr, const Tcl_ObjType *newTypePtr)
129{
  const Tcl_ObjType *typePtr;

  NS_NONNULL_ASSERT(objPtr != NULL)((void) (0));

  typePtr = objPtr->typePtr;
  if (typePtr != NULL((void*)0) && typePtr->freeIntRepProc != NULL((void*)0)) {
      (*typePtr->freeIntRepProc)(objPtr);
  }
  objPtr->typePtr = newTypePtr;
139}

141
142/*
*----------------------------------------------------------------------
*
* Ns_TclSetTwoPtrValue --
*
*      Reset the given objects type and values, freeing any existing
*      internal rep.
*
* Results:
*      None.
*
* Side effects:
*      Depends on object type.
*
*----------------------------------------------------------------------
*/

159void
160Ns_TclSetTwoPtrValue(Tcl_Obj *objPtr, const Tcl_ObjType *newTypePtr,
                   void *ptr1, void *ptr2)
162{
  NS_NONNULL_ASSERT(objPtr != NULL)((void) (0));

  Ns_TclResetObjType(objPtr, newTypePtr);
  objPtr->internalRep.twoPtrValue.ptr1 = ptr1;
  objPtr->internalRep.twoPtrValue.ptr2 = ptr2;
168}

170
171/*
*----------------------------------------------------------------------
*
* Ns_TclSetOtherValuePtr --
*
*      Reset the given objects type and value, freeing any existing
*      internal rep.
*
* Results:
*      None.
*
* Side effects:
*      Depends on object type.
*
*----------------------------------------------------------------------
*/

188void
189Ns_TclSetOtherValuePtr(Tcl_Obj *objPtr, const Tcl_ObjType *newTypePtr, void *value)
190{
  NS_NONNULL_ASSERT(objPtr != NULL)((void) (0));
  NS_NONNULL_ASSERT(newTypePtr != NULL)((void) (0));
  NS_NONNULL_ASSERT(value != NULL)((void) (0));

  Ns_TclResetObjType(objPtr, newTypePtr);
  objPtr->internalRep.otherValuePtr = value;
197}

199
200/*
*----------------------------------------------------------------------
*
* Ns_TclSetStringRep --
*
*      Copy length bytes and set objects string rep.  The objects
*      existing string rep *must* have already been freed. Tcl uses
*      as well "int" and not "size" (internally and via interface)
*
* Results:
*      None.
*
* Side effects:
*      Memory is allocated.
*
*----------------------------------------------------------------------
*/

218void
219Ns_TclSetStringRep(Tcl_Obj *objPtr, const char *bytes, int length)
220{
  NS_NONNULL_ASSERT(objPtr != NULL)((void) (0));
  NS_NONNULL_ASSERT(bytes != NULL)((void) (0));

  if (length < 1) {
      length = (int)strlen(bytes);
  }
  objPtr->length = length;
  objPtr->bytes = ckalloc((unsigned) length + 1u)((void *) Tcl_Alloc((unsigned)((unsigned) length + 1u)));
  memcpy(objPtr->bytes, bytes, (size_t) length + 1u);
230}


233
234/*
*----------------------------------------------------------------------
*
* Ns_TclSetFromAnyError --
*
*      This procedure is registered as the setFromAnyProc for an
*      object type when it doesn't make sense to generate its internal
*      form from the string representation alone.
*
* Results:
*      The return value is always TCL_ERROR, and an error message is
*      left in interp's result if interp isn't NULL.
*
* Side effects:
*      None.
*
*----------------------------------------------------------------------
*/

253int
254Ns_TclSetFromAnyError(Tcl_Interp *interp, Tcl_Obj *UNUSED(objPtr)UNUSED_objPtr __attribute__((__unused__)))
255{
  Tcl_AppendToObj(Tcl_GetObjResult(interp),
                  "can't convert value to requested type except via prescribed API",
                  -1);
  return TCL_ERROR1;
260}

262
263/*
*----------------------------------------------------------------------
*
* Ns_TclGetAddrFromObj --
*
*      Return the internal pointer of an address Tcl_Obj.
*
* Results:
*      TCL_OK or TCL_ERROR if conversion failed or not the correct type.
*
* Side effects:
*      Object may be converted to address type.
*
*----------------------------------------------------------------------
*/

279int
280Ns_TclGetAddrFromObj(Tcl_Interp *interp, Tcl_Obj *objPtr,
                   const char *type, void **addrPtrPtr)
282{
  int result = TCL_OK0;

  NS_NONNULL_ASSERT(objPtr != NULL)((void) (0));
  NS_NONNULL_ASSERT(type != NULL)((void) (0));
  NS_NONNULL_ASSERT(addrPtrPtr != NULL)((void) (0));

  if (Tcl_ConvertToType(interp, objPtr, &addrType) != TCL_OK0) {
      result = TCL_ERROR1;

  } else if (objPtr->internalRep.twoPtrValue.ptr1 != (void *) type) {
      Ns_TclPrintfResult(interp, "incorrect type: %s", Tcl_GetString(objPtr));
      result = TCL_ERROR1;

  } else {
      *addrPtrPtr = objPtr->internalRep.twoPtrValue.ptr2;
  }

  return result;
301}

303
304/*
*----------------------------------------------------------------------
*
* Ns_TclSetAddrObj --
*
*      Convert the given object to the ns:addr type.
*
* Results:
*      None.
*
* Side effects:
*      None.
*
*----------------------------------------------------------------------
*/

320void
321Ns_TclSetAddrObj(Tcl_Obj *objPtr, const char *type, void *addr)
322{
  NS_NONNULL_ASSERT(objPtr != NULL)((void) (0));
  NS_NONNULL_ASSERT(type != NULL)((void) (0));
  NS_NONNULL_ASSERT(addr != NULL)((void) (0));

  if (Tcl_IsShared(objPtr)((objPtr)->refCount > 1)) {
      Tcl_Panic("Ns_TclSetAddrObj called with shared object");
  }
  Ns_TclSetTwoPtrValue(objPtr, &addrType, (void *) type, addr);
  Tcl_InvalidateStringRep(objPtr);
332}

334
335/*
*----------------------------------------------------------------------
*
* Ns_TclGetOpaqueFromObj --
*
*      Get the internal pointer of an address Tcl_Obj.
*
* Results:
*      TCL_OK or TCL_ERROR if object was not of the ns:addr type.
*
* Side effects:
*      None.
*
*----------------------------------------------------------------------
*/

351int
352Ns_TclGetOpaqueFromObj(const Tcl_Obj *objPtr, const char *type, void **addrPtrPtr)
353{
  int result = TCL_OK0;

  NS_NONNULL_ASSERT(objPtr != NULL)((void) (0));
  NS_NONNULL_ASSERT(type != NULL)((void) (0));
  NS_NONNULL_ASSERT(addrPtrPtr != NULL)((void) (0));

  if (objPtr->typePtr == &addrType
      && objPtr->internalRep.twoPtrValue.ptr1 == (void *) type) {
      *addrPtrPtr = objPtr->internalRep.twoPtrValue.ptr2;
  } else {
      char      s[33] = {0};
      uintptr_t t = 0u, a = 0u;

      if ((sscanf(Tcl_GetString((Tcl_Obj *) objPtr), "t%20" SCNxPTR"l" "x" "-a%20" SCNxPTR"l" "x" "-%32s", &t, &a, s) != 3)
          || (strcmp(s, type) != 0)
          || (t != (uintptr_t)type)
          ) {
          result = TCL_ERROR1;
      } else {
          *addrPtrPtr = (void *)a;
      }
  }

  return result;
378}

380
381/*
*----------------------------------------------------------------------
*
* Ns_TclSetOpaqueObj --
*
*      Convert the given object to the ns:addr type without
*      invalidating the current string rep.  It is OK if the object
*      is shared.
*
* Results:
*      None.
*
* Side effects:
*      None.
*
*----------------------------------------------------------------------
*/

399void
400Ns_TclSetOpaqueObj(Tcl_Obj *objPtr, const char *type, void *addr)
401{
  NS_NONNULL_ASSERT(objPtr != NULL)((void) (0));
  NS_NONNULL_ASSERT(type != NULL)((void) (0));

  Ns_TclSetTwoPtrValue(objPtr, &addrType, (void *) type, addr);
406}

408
409/*
*----------------------------------------------------------------------
*
* NsTclObjIsByteArray --
*
*      Does the given Tcl_Obj have a byte array internal rep?  The
*      function determines when it is safe to interpret a string as a
*      byte array directly.
*
* Results:
*      Boolean.
*
* Side effects:
*      None.
*
*----------------------------------------------------------------------
*/

427bool_Bool
428NsTclObjIsByteArray(const Tcl_Obj *objPtr)
429{
  bool_Bool result;

  NS_NONNULL_ASSERT(objPtr != NULL)((void) (0));

  /*
   * This function resembles the tclInt.h function for testing pure byte
   * arrays. In versions up to at least on Tcl 8.6, a pure byte array was
   * defined as a byte array without a string rep.  Starting with Tcl
   * 8.7a1, Tcl has introduced the properByteArrayTypePtr, which allows as
   * well a string rep.
   */
441#ifdef NS_TCL_PRE87
  result = ((objPtr->typePtr == byteArrayTypePtr) && (objPtr->bytes == NULL((void*)0)));
443#else
  result = (objPtr->typePtr == properByteArrayTypePtr);
445#endif

447#if 0
  fprintf(stderr, "NsTclObjIsByteArray? %p type %p proper %d old %d bytes %p name %s => %d\n",__fprintf_chk (stderr, 2 - 1, "NsTclObjIsByteArray? %p type %p proper %d old %d bytes %p name %s => %d\n"
, (void*)objPtr, (void*)(objPtr->typePtr), (objPtr->typePtr
 == properByteArrayTypePtr), (objPtr->typePtr == byteArrayTypePtr
), (void*)(objPtr->bytes), objPtr->typePtr == ((void*)0
) ? "string" : objPtr->typePtr->name, result)
          (void*)objPtr,__fprintf_chk (stderr, 2 - 1, "NsTclObjIsByteArray? %p type %p proper %d old %d bytes %p name %s => %d\n"
, (void*)objPtr, (void*)(objPtr->typePtr), (objPtr->typePtr
 == properByteArrayTypePtr), (objPtr->typePtr == byteArrayTypePtr
), (void*)(objPtr->bytes), objPtr->typePtr == ((void*)0
) ? "string" : objPtr->typePtr->name, result)
          (void*)(objPtr->typePtr),__fprintf_chk (stderr, 2 - 1, "NsTclObjIsByteArray? %p type %p proper %d old %d bytes %p name %s => %d\n"
, (void*)objPtr, (void*)(objPtr->typePtr), (objPtr->typePtr
 == properByteArrayTypePtr), (objPtr->typePtr == byteArrayTypePtr
), (void*)(objPtr->bytes), objPtr->typePtr == ((void*)0
) ? "string" : objPtr->typePtr->name, result)
          (objPtr->typePtr == properByteArrayTypePtr),__fprintf_chk (stderr, 2 - 1, "NsTclObjIsByteArray? %p type %p proper %d old %d bytes %p name %s => %d\n"
, (void*)objPtr, (void*)(objPtr->typePtr), (objPtr->typePtr
 == properByteArrayTypePtr), (objPtr->typePtr == byteArrayTypePtr
), (void*)(objPtr->bytes), objPtr->typePtr == ((void*)0
) ? "string" : objPtr->typePtr->name, result)
          (objPtr->typePtr == byteArrayTypePtr),__fprintf_chk (stderr, 2 - 1, "NsTclObjIsByteArray? %p type %p proper %d old %d bytes %p name %s => %d\n"
, (void*)objPtr, (void*)(objPtr->typePtr), (objPtr->typePtr
 == properByteArrayTypePtr), (objPtr->typePtr == byteArrayTypePtr
), (void*)(objPtr->bytes), objPtr->typePtr == ((void*)0
) ? "string" : objPtr->typePtr->name, result)
          (void*)(objPtr->bytes),__fprintf_chk (stderr, 2 - 1, "NsTclObjIsByteArray? %p type %p proper %d old %d bytes %p name %s => %d\n"
, (void*)objPtr, (void*)(objPtr->typePtr), (objPtr->typePtr
 == properByteArrayTypePtr), (objPtr->typePtr == byteArrayTypePtr
), (void*)(objPtr->bytes), objPtr->typePtr == ((void*)0
) ? "string" : objPtr->typePtr->name, result)
          objPtr->typePtr == NULL ? "string" : objPtr->typePtr->name,__fprintf_chk (stderr, 2 - 1, "NsTclObjIsByteArray? %p type %p proper %d old %d bytes %p name %s => %d\n"
, (void*)objPtr, (void*)(objPtr->typePtr), (objPtr->typePtr
 == properByteArrayTypePtr), (objPtr->typePtr == byteArrayTypePtr
), (void*)(objPtr->bytes), objPtr->typePtr == ((void*)0
) ? "string" : objPtr->typePtr->name, result)
          result)__fprintf_chk (stderr, 2 - 1, "NsTclObjIsByteArray? %p type %p proper %d old %d bytes %p name %s => %d\n"
, (void*)objPtr, (void*)(objPtr->typePtr), (objPtr->typePtr
 == properByteArrayTypePtr), (objPtr->typePtr == byteArrayTypePtr
), (void*)(objPtr->bytes), objPtr->typePtr == ((void*)0
) ? "string" : objPtr->typePtr->name, result);
456#endif

  return result;
459}

461
462/*
*----------------------------------------------------------------------
*
* NsTclObjIsEncodedByteArray --
*
*      This function is true, when we encounter a bytearray with a string
*      rep.  In this cases, it is necessary to use Tcl_UtfToExternalDString()
*      to obtain the proper byte array.
*
* Results:
*      Boolean.
*
* Side effects:
*      None.
*
*----------------------------------------------------------------------
*/

480bool_Bool
481NsTclObjIsEncodedByteArray(const Tcl_Obj *objPtr)
482{
  NS_NONNULL_ASSERT(objPtr != NULL)((void) (0));

  return ((objPtr->typePtr == byteArrayTypePtr) && (objPtr->bytes != NULL((void*)0)));
486}

488
489/*
*----------------------------------------------------------------------
*
* UpdateStringOfAddr --
*
*      Update the string representation for an address object.
*      Note: This procedure does not free an existing old string rep
*      so storage will be lost if this has not already been done.
*
* Results:
*      None.
*
* Side effects:
*      None.
*
*----------------------------------------------------------------------
*/

507static void
508UpdateStringOfAddr(Tcl_Obj *objPtr)
509{
  const char *type = objPtr->internalRep.twoPtrValue.ptr1;
  const void *addr = objPtr->internalRep.twoPtrValue.ptr2;
  char        buf[128];
  int         len;

  len = snprintf(buf, sizeof(buf), "t%" PRIxPTR "-a%" PRIxPTR "-%s", (uintptr_t)type, (uintptr_t)addr, type)__builtin___snprintf_chk (buf, sizeof(buf), 2 - 1, __builtin_object_size
 (buf, 2 > 1), "t%" "l" "x" "-a%" "l" "x" "-%s", (uintptr_t
)type, (uintptr_t)addr, type);
  Ns_TclSetStringRep(objPtr, buf, len);
517}

519
520/*
*----------------------------------------------------------------------
*
* SetAddrFromAny --
*
*      Attempt to generate an address internal form for the Tcl_Obj.
*
* Results:
*      The return value is a standard Tcl result. If an error occurs
*      during conversion, an error message is left in the interpreter's
*      result unless interp is NULL.
*
* Side effects:
*      None.
*
*----------------------------------------------------------------------
*/

538static int
539SetAddrFromAny(Tcl_Interp *interp, Tcl_Obj *objPtr)
540{
  int   result = TCL_OK0;
  void *type, *addr;
  char *chars;

  chars = Tcl_GetString(objPtr);
  if ((sscanf(chars, "t%20p-a%20p", &type, &addr) != 2)
      || (type == NULL((void*)0))
      || (addr == NULL((void*)0))
      ) {
      Ns_TclPrintfResult(interp, "invalid address \"%s\"", chars);
      result = TCL_ERROR1;
  } else {
      Ns_TclSetTwoPtrValue(objPtr, &addrType, type, addr);
  }

  return result;
557}


560/*
* Local Variables:
* mode: c
* c-basic-offset: 4
* fill-column: 78
* indent-tabs-mode: nil
* End:
*/